The C Source, Patches and (shudder!) Bugs
Post Reply

Josh
Site Admin
Posts: 6570
Joined: 03 Nov 2007, 00:30

Re: Fix crash on early fail

Post by Josh » 21 Jul 2016, 09:23

Hmm, that bug report seems not to be public yet ... Can't see it.

Edit: to be more precise - it says I can't see it without logging in.

LOM
Posts: 1380
Joined: 11 Jul 2012, 15:14
Location: Koh Samui, TH

Re: Fix crash on early fail

Post by LOM » 21 Jul 2016, 11:47

Logging in doesn't get you any further, the bug seems to be RedHat specific and not something we should care about.
You are not authorized to access bug #1358472.

Most likely the bug has been restricted for internal development processes and we cannot grant access.

lkundrak
Posts: 24
Joined: 22 Jun 2016, 14:17

Re: Fix crash on early fail

Post by lkundrak » 21 Jul 2016, 18:53

Sorry, my bad. The bug was automatically filed and I didn't realize it defaults to private. There's nothing secret there; nor too much interesting stuff -- just a traceback and the patch.

Josh
Site Admin
Posts: 6570
Joined: 03 Nov 2007, 00:30

Re: Fix crash on early fail

Post by Josh » 22 Jul 2016, 10:55

I'll try to wrap the whole thing up because it was not immediately clear to me what this is all about:

There was some automatic Fedora package auditing, and it discovered a crash if the command line parameter "-c" was given a file name of a non-existent file.

Is that correct?

Anyway, I will test this and apply the patch accordingly.
However, the priority is not very high as the "-c" parameter is never used in the standard 'automatic' setup. The bug will affect only people who run usb_modeswitch manually on the command line.

lkundrak
Posts: 24
Joined: 22 Jun 2016, 14:17

Re: Fix crash on early fail

Post by lkundrak » 18 Aug 2017, 10:42

No, the testing was not automatic really; I was hunting down another bug (see http://www.draisberghof.de/usb_modeswit ... f=2&t=2557) and happened to call the tool with a wrong parameter. The crash was then caught by ABRT which makes it convenient to track the crashes and also saves the core.

Agreed about the severity -- not too important at all.

The another bug hits undefined behavior and indeed makes usb_modeswitch act very unpredictably though; that's a bit more severe. Patched it for Fedora already, but other distros may need a fix too.


Last bumped by lkundrak on 18 Aug 2017, 10:42.

Post Reply