The C Source, Patches and (shudder!) Bugs
Post Reply
lkundrak
Posts: 24
Joined: 22 Jun 2016, 14:17

don't return a value from stack

Post by lkundrak » 21 Jul 2016, 18:55

Please see the attached patch.

Thank you
Lubo
Attachments
0001-usb_modeswitch-don-t-return-a-value-from-stack.patch
Suggested fix
(1.05 KiB) Downloaded 434 times

lkundrak
Posts: 24
Joined: 22 Jun 2016, 14:17

Re: don't return a value from stack

Post by lkundrak » 07 Sep 2016, 20:13

Ping? This is probably quite serious; at least when built in Fedora the behavior of usb_modeswitch without the patch was totally unpredictable (did the job in ~50% of cases).
Could be the compiler flags we use, but perhaps that happens for other distros too?

Josh
Site Admin
Posts: 6570
Joined: 03 Nov 2007, 00:30

Re: don't return a value from stack

Post by Josh » 08 Sep 2016, 08:13

There were no other reports about such a problem on other distros, AFAIK. Is there an official Fedora bug report?

I will certainly include the patch with the next program package update.

lkundrak
Posts: 24
Joined: 22 Jun 2016, 14:17

Re: don't return a value from stack

Post by lkundrak » 08 Sep 2016, 12:14

Josh wrote:There were no other reports about such a problem on other distros, AFAIK. Is there an official Fedora bug report?
Not really. I've stumbled upon this myself when checking things work well with my modem collection after updating the package. The users don't tend to include too much details in the bug reports -- there's a handful of "my modem won't work" bug reports filed against ModemManager that lack good explanation. I merely suspected this could be related.

Post Reply